When we were kids, it was rocks. We collected your garden variety rocks, but treated them like gems. We would pore over the entire backyard and find the best rocks and would them wash and dry them and put them away in a VCR tape box. (Yeah, we don't know why we picked a VCR tape box either...)
What do your children like to collect? Please share!